Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestClient::BadRequest Error and JSON::ParseError not Caught #40

Open
sshaw opened this issue May 25, 2019 · 0 comments
Open

RestClient::BadRequest Error and JSON::ParseError not Caught #40

sshaw opened this issue May 25, 2019 · 0 comments

Comments

@sshaw
Copy link

sshaw commented May 25, 2019

Using v2.6.5.

There's a ChargeBee::Error class but this code does not handle all exceptions so RestClient::BadRequest squeaks through.

The exception is not documented (as most Ruby libs and their exceptions aren't) but it and others are placed into the RestClient::Exceptions::EXCEPTION_MAP constant.


No JSON exceptions are caught here.


There's probably more but that's what I've seen so far.

Also note that RESTClient seems dead. But, maybe that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant