False positive caused by brackets

[sb10]

time.Duration(attempts) * time.Millisecond is fine, but
time.Duration((attempts)) * time.Millisecond causes a false positive.

(The real scenario was doing some maths inside the time.Duration(): time.Duration((attempts-1)*2)*time.Millisecond).)

[charithe]

Thanks. This is fixed in v0.0.7.

[Gentoli]

Seems when the bracketed case have no space it will still fail:
time.Duration((c + 1) * 200) * time.Millisecond will pass,
time.Duration((c+1)*200) * time.Millisecond fails

[charithe]

Hmm...I can't reproduce that case. First of all, I had to disable gofmt to even type in the expression without spaces. When I eventually did, the linter was still happy. I can't see why it wouldn't be because it's using the AST produced by the Go parser and spaces are irrelevant to the parser.

[Gentoli]

I am using https://github.com/golangci/golangci-lint to call durationcheck, maybe something is wrong on their side..

[charithe]

I still can't reproduce with either golangcl-lint (1.40.2) or the standalone linter. Weird! 🤷🏽

[Gentoli]

I just realized golangcl-lint (1.40.1) is still on 0.6 🤦. Installing the latest resolved the issue. Thank you for checking 🙏.