Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the code in Readme wrong? #18

Closed
frederikhors opened this issue Sep 4, 2021 · 3 comments · Fixed by #19
Closed

Why is the code in Readme wrong? #18

frederikhors opened this issue Sep 4, 2021 · 3 comments · Fixed by #19

Comments

@frederikhors
Copy link

Can I ask you why the code in Readme is wrong?

func waitFor(someDuration time.Duration) {
    timeToWait := someDuration * time.Second
    time.Sleep(timeToWait)
}
@frederikhors
Copy link
Author

I just found golang/go#20757.

@charithe
Copy link
Owner

charithe commented Sep 4, 2021

It's not syntactically wrong but it's semantically wrong.

Perhaps this will explain it better: #11 (comment)

@frederikhors
Copy link
Author

Can you please explain it better in Readme?

@charithe charithe mentioned this issue Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example in README charithe/durationcheck
2 participants
@charithe @frederikhors