Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with golangci-lint #6

Closed
SVilgelm opened this issue Jan 11, 2021 · 3 comments
Closed

integration with golangci-lint #6

SVilgelm opened this issue Jan 11, 2021 · 3 comments

Comments

@SVilgelm
Copy link

SVilgelm commented Jan 11, 2021

Hi,
I found you linter is very useful, but it would be great if you can integrate it with golangci-lint
I did an attempt, but looks like it requires some changes in your code

@charithe
Copy link
Owner

Where did you stumble with the integration? Do you know what needs to change?

@ldez
Copy link
Contributor

ldez commented Feb 14, 2021

Hello,

I created an integration with golangci-lint and I don't see any issue with this linter.

golangci/golangci-lint#1734

@SVilgelm am I missing something?

@charithe
Copy link
Owner

Nice work @ldez. Thank you.

Since @ldez has kindly taken on the integration work and raised a PR against golangci-lint, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants