Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass className to Selector #114

Open
justemoilouise opened this issue Sep 9, 2021 · 11 comments
Open

Pass className to Selector #114

justemoilouise opened this issue Sep 9, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@justemoilouise
Copy link
Contributor

Ideally, it would be nice to be able to pass a className into the selectors so users could add their own styles into it - background-color, etc.

Screen Shot 2021-09-09 at 6 32 23 PM

@charkour
Copy link
Owner

charkour commented Sep 9, 2021

I agree. Want to make a PR? I'm a little busy this week so it would be a bit until I can add this.

@justemoilouise
Copy link
Contributor Author

@charkour I'd be happy to do it. I'll create one as soon as I have time. 😁

@charkour
Copy link
Owner

charkour commented Sep 9, 2021

Thanks! I appreciate it.

@charkour charkour added the enhancement New feature or request label Oct 3, 2021
@charkour
Copy link
Owner

charkour commented Oct 3, 2021

@justemoilouise, which selectors would you like this to apply to? All of them?

Also, are you actively working on this? If yes, I can assign you to this issue. Thanks

@justemoilouise
Copy link
Contributor Author

@charkour it would be nice to apply it to all of them. I haven't started working on this. 😅

@charkour
Copy link
Owner

charkour commented Oct 4, 2021

Alright, thanks for the update!

  • Facebook Selector (and Pokemon Selector)
  • GitHub Selector
  • Slack Selector
  • Custom Selector

We can use this to track updates. I'm not sure when I'll get time to do this either. But I'll update this if I start to work on it. Or you can let me know if you do. Thanks!!

@charkour charkour self-assigned this Jul 3, 2022
@lagroms
Copy link

lagroms commented Sep 13, 2022

Hello,

Is there any news regarding the custom styling feature ?

Thanks !

@charkour
Copy link
Owner

Hey @lagroms,

Right now this custom styling feature is supported for the Custom Selector. Do you need support for other selectors?

Thanks

@lagroms
Copy link

lagroms commented Sep 14, 2022

Well I'm using the custom ReactionBarSelector, but no custom class in being applied in my case. Maybe I'm missing something ?

I'm using css-modules in my case :

const Reactions = ({ onSelect }) => {
    return (
        <ReactionBarSelector
            className={styles.reactions_container}
            reactions={reactionOptions}
            onSelect={onSelect}
        />
    );
};

@lagroms
Copy link

lagroms commented Sep 14, 2022

My bad, my question was regarding the ability to add a className on the component, instead of passing the style directly to it, and also have more control on the rest.

For exemple, i'd like to style the labels, not sure this is currently possible ?

Thanks.

@charkour
Copy link
Owner

Hi @lagroms!

Currently it is not possible to style the labels, but that is a great idea. Would you be willing to make a PR for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants