Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like not working on mobile touch #132

Closed
gh4m21 opened this issue Apr 13, 2022 · 8 comments
Closed

Like not working on mobile touch #132

gh4m21 opened this issue Apr 13, 2022 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@gh4m21
Copy link

gh4m21 commented Apr 13, 2022

Describe the bug
The reactions components CustomReaction work perfectly on desktop, but when I try to click on the icon on mobile, it shows click in the console and nothing.

code

<Fragment> <ReactionBarSelector className="bg-secondary" iconSize={"28px"} reactions={reactions} onSelect={(label) => handleReaction(label)} /> </Fragment>

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Iphone 11 pro max
  • OS: IOS 15.3.1
  • Browser safari
  • Version last version
@charkour
Copy link
Owner

Thanks for the report. I can look at it tonight.

@charkour
Copy link
Owner

Would you be willing to post a code sandbox with a reproduction of the issue? Thanks!

@gh4m21
Copy link
Author

gh4m21 commented Apr 13, 2022

Thanks for the report. I can look at it tonight.

Thank you so much.
I will add a code sandbox

@gh4m21
Copy link
Author

gh4m21 commented Apr 13, 2022

https://codesandbox.io/s/issue-react-reactions-with-mobile-touch-e7hpnd

@charkour
Copy link
Owner

Hi @gh4m21, thanks for the sandbox. Here is a video I recorded. When I tap an icon, it will correctly console log. Do you expect the icon to shrink to its original size after clicking? Thanks.

Upload.from.GitHub.for.iOS.MOV

@charkour charkour self-assigned this Apr 14, 2022
@charkour charkour added the question Further information is requested label Apr 14, 2022
@gh4m21
Copy link
Author

gh4m21 commented Apr 14, 2022

Hi @gh4m21, thanks for the sandbox. Here is a video I recorded. When I tap an icon, it will correctly console log. Do you expect the icon to shrink to its original size after clicking? Thanks.

Upload.from.GitHub.for.iOS.MOV

Thank you so much for helping me.
I got it now. Finally, using a Tooltip to show the component in the perfect place was not a good idea.
I will try to use popover, a modal something else...

@charkour
Copy link
Owner

Great thanks for the reply. Can I close this issue?

@gh4m21
Copy link
Author

gh4m21 commented Apr 14, 2022

Great thanks for the reply. Can I close this issue?

Go ahead.

@gh4m21 gh4m21 closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants