Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector and Counter Bundlize as one #144

Open
c0ncentus opened this issue Jul 5, 2022 · 4 comments
Open

Selector and Counter Bundlize as one #144

c0ncentus opened this issue Jul 5, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@c0ncentus
Copy link

c0ncentus commented Jul 5, 2022

Is your feature request related to a problem? Please describe.

Add one type of Component, One for rule the all !
Exemple <Bundlize counter={<GithubCounter_ />} Selectors={<SlackSelector_ />} events={(e)=>{}} />

Describe the solution you'd like
it would be appreciable to have this instantly without managing events/state all the times
image
it would make sens in <Bundlize counter={<GithubCounter_ />} Selectors={ /> events links are bound ...

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Component are seperate UI and visual concept, but would make sens to make as one for user commun use !

@charkour
Copy link
Owner

charkour commented Jul 5, 2022

Hey @c0ncentus,

Thanks for the great suggestion! And thank you for using the package for a long time.

To clarify, would you like a component with a counter and selector so that the state can be shared between the two? Currently, there has to be a parent component that manages the state and shares it between the two?

I like this idea, but it might take longer to implement.

@charkour charkour added the enhancement New feature or request label Jul 5, 2022
@c0ncentus
Copy link
Author

c0ncentus commented Jul 5, 2022

"To clarify, would you like a component with a counter and selector so that the state can be shared between the two?"

Yes completely.

"Currently, there has to be a parent component that manages the state and shares it between the two?"

Yes currently, it is ! thats why my suggestion.

an alternative use

<Bundle>
    <Counter/>
    <Selector/>
</Bundle>

But not sure if it's work. But if only 1 configuration is available (Counter and Selector) will be fine with events.

I'm ok with the time.
Thanks to maintain this awesome UI features !

@charkour
Copy link
Owner

charkour commented Jul 5, 2022

Thanks for the quick response!

I like the <Bundle> as a parent so that we can use Context. The <Bundle> can be a provider.

I'll come up with an API and ask for your feedback in about a week's time.

@charkour
Copy link
Owner

Hey @c0ncentus,

I like the simple API example you provided. I haven't had time yet to work on it so I can't guarantee when it will be released. You are welcome to try making a PR that adds this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants