Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test with named enum values #348

Merged
merged 2 commits into from Jan 28, 2023

Conversation

Kantis
Copy link
Contributor

@Kantis Kantis commented Nov 19, 2022

Hi @charleskorn

I ran into some trouble when parsing an enum with explicit serial names into a config using Hoplite. Was trying to pinpoint the issue, and it seems it's not in KAML 🙂 If you feel there's any value to adding the tests you're welcome to merge this, otherwise just close it.

@charleskorn
Copy link
Owner

Thanks for the PR @Kantis (and glad to hear the issue wasn't in kaml 😄).

Looks like the linter doesn't like the underscore: https://github.com/charleskorn/kaml/actions/runs/3503957206/jobs/5972329516#step:8:50

Could you please take a look at this? Once this is fixed, I'll merge it.

@stale
Copy link

stale bot commented Jan 25, 2023

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues.
If this issue is still affecting you, please comment below within the next seven days.
Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2023
@Kantis Kantis force-pushed the adding-test-with-named-enums branch from b833bf7 to 0b503c2 Compare January 26, 2023 06:52
@stale stale bot removed the stale label Jan 26, 2023
@Kantis
Copy link
Contributor Author

Kantis commented Jan 26, 2023

@charleskorn sorry, forgot about this one. Fixed now and checks are passing locally at least ✌🏼

@charleskorn
Copy link
Owner

Thanks @Kantis!

@charleskorn charleskorn merged commit f40ac61 into charleskorn:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants