-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images rendering incorrect #12
Comments
Hi @mtt87! I just tried to reproduce your bug with 2 images, but I couldn't, here's the output: Did you apply another style that could be interfering with it? |
These are the styles I'm applying: const stylesMarkdown = {
image: {
width: Dimensions.get('window').width - 30,
height: 300,
resizeMode: 'contain',
marginTop: 15,
marginBottom: 15,
flex: 1,
},
paragraph: {
fontFamily: 'Roboto',
// fontSize: 14,
// lineHeight: 19,
},
}; |
One of the reasons could be |
I'm gonna try this tomorrow, sorry for the delay 😄 I was building other features |
No way, still it happens (only with import React from 'react';
import {
StyleSheet,
Text,
ScrollView,
Dimensions,
} from 'react-native';
import Markdown from 'react-native-simple-markdown';
import moment from 'moment';
const styles = StyleSheet.create({
container: {
flex: 1,
padding: 15,
marginTop: 65,
marginBottom: 55,
flexDirection: 'column',
},
title: {
textAlign: 'center',
fontSize: 22,
fontWeight: 'bold',
marginBottom: 15,
color: '#333',
},
});
const stylesMarkdown = {
image: {
width: Dimensions.get('window').width - 30,
height: 300,
marginTop: 15,
marginBottom: 15,
},
paragraph: {
fontFamily: 'Roboto',
fontSize: 15,
// lineHeight: 19,
},
};
const SingleEvent = ({ markdown, eventData }) =>
<ScrollView style={styles.container}>
<Text style={styles.title}>
{eventData.title}
</Text>
<Text style={{ textAlign: 'center', fontSize: 16, color: '#555' }}>
{moment(eventData.event_start, 'YYYY-MM-DD HH:mm:ss').format('DD MMM HH:mm')}
</Text>
<Text style={{ textAlign: 'center', fontSize: 16, marginBottom: 20, color: '#555' }}>
{eventData.venue_name}
</Text>
<Markdown styles={stylesMarkdown}>
{markdown}
</Markdown>
</ScrollView>;
SingleEvent.propTypes = {
markdown: React.PropTypes.string,
eventData: React.PropTypes.shape({
title: React.PropTypes.string.isRequired,
event_start: React.PropTypes.string.isRequired,
venue_name: React.PropTypes.string.isRequired,
}),
};
export default SingleEvent; |
Hi @mtt87! Sorry for the delay! Do you still have the same problem? |
@CharlesMangwa Yes in the end I've submitted the app without that change. |
@mtt87 I didn't spot anything that could cause this issue 😕… I'll try again to reproduce it and fix it asap! |
Closing issue #12 |
Hi, I noticed that if I try to style the
paragraph
withlineHeight
or changing thefontSize
I get images above the text and they are incorrectly rendered.Do you have an idea why this is happening?
Thank you 😄
Without the
![screen shot 2016-10-25 at 12 21 55](https://cloud.githubusercontent.com/assets/2150927/19684167/a809c6a2-9aad-11e6-87f5-0ece72a2829f.png)
lineHeight
propertyThe text was updated successfully, but these errors were encountered: