Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images rendering incorrect #12

Closed
mtt87 opened this issue Oct 25, 2016 · 9 comments
Closed

Images rendering incorrect #12

mtt87 opened this issue Oct 25, 2016 · 9 comments
Labels

Comments

@mtt87
Copy link

mtt87 commented Oct 25, 2016

Hi, I noticed that if I try to style the paragraph with lineHeight or changing the fontSize I get images above the text and they are incorrectly rendered.

Do you have an idea why this is happening?

Thank you 😄

screen shot 2016-10-25 at 12 19 28

Without the lineHeight property
screen shot 2016-10-25 at 12 21 55

@CharlesMangwa
Copy link
Owner

Hi @mtt87! I just tried to reproduce your bug with 2 images, but I couldn't, here's the output:
capture d ecran 2016-10-29 a 10 19 47

Did you apply another style that could be interfering with it?

@mtt87
Copy link
Author

mtt87 commented Nov 1, 2016

These are the styles I'm applying:

const stylesMarkdown = {
  image: {
    width: Dimensions.get('window').width - 30,
    height: 300,
    resizeMode: 'contain',
    marginTop: 15,
    marginBottom: 15,
    flex: 1,
  },
  paragraph: {
    fontFamily: 'Roboto',
    // fontSize: 14,
    // lineHeight: 19,
  },
};

@CharlesMangwa
Copy link
Owner

CharlesMangwa commented Nov 1, 2016

One of the reasons could be resizeMode. For the time being, you have to set it as a normal rule like image or paragraph. But by default it's set at contain so: you don't need to define it there.
Also: did you try to remove the flex: 1? Considering that you've already set a width & height, this is maybe not useful. Tell me if it helps!

@mtt87
Copy link
Author

mtt87 commented Nov 8, 2016

I'm gonna try this tomorrow, sorry for the delay 😄 I was building other features

@mtt87
Copy link
Author

mtt87 commented Nov 9, 2016

No way, still it happens (only with lineHeight)
As reference this is the full code of the page

import React from 'react';
import {
  StyleSheet,
  Text,
  ScrollView,
  Dimensions,
} from 'react-native';
import Markdown from 'react-native-simple-markdown';
import moment from 'moment';

const styles = StyleSheet.create({
  container: {
    flex: 1,
    padding: 15,
    marginTop: 65,
    marginBottom: 55,
    flexDirection: 'column',
  },
  title: {
    textAlign: 'center',
    fontSize: 22,
    fontWeight: 'bold',
    marginBottom: 15,
    color: '#333',
  },
});

const stylesMarkdown = {
  image: {
    width: Dimensions.get('window').width - 30,
    height: 300,
    marginTop: 15,
    marginBottom: 15,
  },
  paragraph: {
    fontFamily: 'Roboto',
    fontSize: 15,
    // lineHeight: 19,
  },
};

const SingleEvent = ({ markdown, eventData }) =>
  <ScrollView style={styles.container}>
    <Text style={styles.title}>
      {eventData.title}
    </Text>
    <Text style={{ textAlign: 'center', fontSize: 16, color: '#555' }}>
      {moment(eventData.event_start, 'YYYY-MM-DD HH:mm:ss').format('DD MMM HH:mm')}
    </Text>
    <Text style={{ textAlign: 'center', fontSize: 16, marginBottom: 20, color: '#555' }}>
      {eventData.venue_name}
    </Text>
    <Markdown styles={stylesMarkdown}>
      {markdown}
    </Markdown>
  </ScrollView>;

SingleEvent.propTypes = {
  markdown: React.PropTypes.string,
  eventData: React.PropTypes.shape({
    title: React.PropTypes.string.isRequired,
    event_start: React.PropTypes.string.isRequired,
    venue_name: React.PropTypes.string.isRequired,
  }),
};

export default SingleEvent;

@CharlesMangwa
Copy link
Owner

Hi @mtt87! Sorry for the delay! Do you still have the same problem?

@mtt87
Copy link
Author

mtt87 commented Nov 28, 2016

@CharlesMangwa Yes in the end I've submitted the app without that change.
Can you spot something strange in my code? 😄

@CharlesMangwa
Copy link
Owner

@mtt87 I didn't spot anything that could cause this issue 😕… I'll try again to reproduce it and fix it asap!

@CharlesMangwa
Copy link
Owner

Closing issue #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants