Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about train_one_step() method. #4

Closed
sshpark opened this issue Nov 17, 2020 · 3 comments
Closed

A question about train_one_step() method. #4

sshpark opened this issue Nov 17, 2020 · 3 comments

Comments

@sshpark
Copy link
Contributor

sshpark commented Nov 17, 2020

X, y = self.get_next_test_batch()

Hi CharlieDinh, I' m Sorry to take up your time. Can you tell me why self.get_next_test_batch() is used to do the update in the first step and then self.get_next_train_batch() is used to do the update in the second step? Can I do both updates with self.get_next_train_batch() ?

@hesetone
Copy link

X, y = self.get_next_test_batch()

Hi CharlieDinh, I' m Sorry to take up your time. Can you tell me why self.get_next_test_batch() is used to do the update in the first step and then self.get_next_train_batch() is used to do the update in the second step? Can I do both updates with self.get_next_train_batch() ?

se se fa dou, orz, ......

@CharlieDinh
Copy link
Owner

Hi Sshpark, Sorry for the late reply. I've seen your comment yet.
Actually, PerFedAvg �requires a one-step update using the test data. So both should be get_next_test_batch. I updated the code.

@sshpark
Copy link
Contributor Author

sshpark commented Nov 27, 2020

Hi Sshpark, Sorry for the late reply. I've seen your comment yet.
Actually, PerFedAvg �requires a one-step update using the test data. So both should be get_next_test_batch. I updated the code.

Thank you very much for your answer!

@sshpark sshpark closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants