Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vi locale #18

Merged
merged 2 commits into from Oct 11, 2016
Merged

Add vi locale #18

merged 2 commits into from Oct 11, 2016

Conversation

imcvampire
Copy link
Contributor

No description provided.

@charliekassel
Copy link
Owner

Hey @imcvampire this PR breaks the build. Can you look at it again please?

@coveralls
Copy link

coveralls commented Oct 11, 2016

Coverage Status

Coverage increased (+7.2%) to 99.598% when pulling 5eaf674 on imcvampire:master into 55db115 on charliekassel:master.

@imcvampire
Copy link
Contributor Author

@charliekassel I just fixed it. Can you review my MR.

@charliekassel
Copy link
Owner

Great, thanks! Do you want to add it to the available languages in the readme?

@imcvampire
Copy link
Contributor Author

Of course yes. Thank you for very nice plugin.

@imcvampire
Copy link
Contributor Author

Moreover, I want to upgrade your plugin to compatible with vuejs 2. But I don't know do you mind if I do it?

@charliekassel
Copy link
Owner

Unfortunately my organisation where I'm using this component is not yet ready for 2.0 so I can't make the change yet.

From a compatibility check using vue-migration-helper I believe all that will be needed is to switch the ready() hook for mounted() - I think I've changed everything else to make it compatible.

@imcvampire
Copy link
Contributor Author

I find you use .sync in your v-bind.

So do you mind if I fork your repo and create a version for Vuejs 2.0 ?

@charliekassel
Copy link
Owner

.sync is not used in the component - only in the readme documentation

@imcvampire imcvampire closed this Oct 11, 2016
@charliekassel
Copy link
Owner

Why did you close @imcvampire ?

@imcvampire
Copy link
Contributor Author

imcvampire commented Oct 11, 2016

Ops. My internet just has some problem and I do a wrong click!!! I'm sorry.

About .sync what I mean that you don't provide any others way to do that. I want to talk about something like $emit (http://vuejs.org/api/#vm-emit)

@imcvampire imcvampire reopened this Oct 11, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+7.2%) to 99.598% when pulling 5eaf674 on imcvampire:master into 55db115 on charliekassel:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+7.2%) to 99.598% when pulling 5eaf674 on imcvampire:master into 55db115 on charliekassel:master.

@charliekassel
Copy link
Owner

I can probably do a direct swap with $dispatch and $emit.
I will test and if so I'll make the change.

@charliekassel charliekassel merged commit 4feee41 into charliekassel:master Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants