Ignore relative imports in banned-api rules (#4024)

astral-sh · Apr 19, 2023 · c4cda30 · c4cda30
1 parent 13fda30
commit c4cda30
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/crates/ruff/resources/test/fixtures/flake8_tidy_imports/TID251.py b/crates/ruff/resources/test/fixtures/flake8_tidy_imports/TID251.py
@@ -31,3 +31,6 @@
 # import aliases are resolved
 import typing as totally_not_typing
 totally_not_typing.TypedDict
+
+# relative imports are respected
+from .typing import TypedDict
diff --git a/crates/ruff/src/checkers/ast/mod.rs b/crates/ruff/src/checkers/ast/mod.rs
@@ -1155,13 +1155,15 @@ where
                 }
 
                 if self.settings.rules.enabled(Rule::BannedApi) {
-                    if let Some(module) = module {
-                        for name in names {
-                            flake8_tidy_imports::banned_api::name_is_banned(self, module, name);
+                    if level.map_or(true, |level| level == 0) {
+                        if let Some(module) = module {
+                            for name in names {
+                                flake8_tidy_imports::banned_api::name_is_banned(self, module, name);
+                            }
+                            flake8_tidy_imports::banned_api::name_or_parent_is_banned(
+                                self, module, stmt,
+                            );
                         }
-                        flake8_tidy_imports::banned_api::name_or_parent_is_banned(
-                            self, module, stmt,
-                        );
                     }
                 }
 

diff --git a/...shots/ruff__rules__flake8_tidy_imports__banned_api__tests__banned_api_true_positives.snap b/...shots/ruff__rules__flake8_tidy_imports__banned_api__tests__banned_api_true_positives.snap
@@ -113,6 +113,8 @@ TID251.py:33:1: TID251 `typing.TypedDict` is banned: Use typing_extensions.Typed
 34 | import typing as totally_not_typing
 35 | totally_not_typing.TypedDict
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TID251
+36 | 
+37 | # relative imports are respected
    |