Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exempt parameters with immutable annotations from B006 #821

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Exempt parameters with immutable annotations from B006 #821

merged 1 commit into from
Nov 20, 2022

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 19, 2022

Fixes #572.

@andersk andersk force-pushed the immutable-annotation branch 3 times, most recently from 02267a0 to 8a8f337 Compare November 20, 2022 00:04
@andersk
Exempt parameters with immutable annotations from B006
cdb5f8f 
Fixes astral-sh#572.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
charliermarsh
charliermarsh reviewed Nov 20, 2022
View reviewed changes
src/flake8_bugbear/plugins/mutable_argument_default.rs
expr: &Expr,
from_imports: &FnvHashMap<&str, FnvHashSet<&str>>,
import_aliases: &FnvHashMap<&str, &str>,
) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@charliermarsh
Copy link
Member

This looks great.

@charliermarsh charliermarsh merged commit 4161d4a into astral-sh:main Nov 20, 2022
@andersk andersk deleted the immutable-annotation branch November 20, 2022 01:59
@andersk andersk mentioned this pull request Apr 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

B006 (MutableArgumentDefault) should exempt parameters with immutable type annotations
2 participants
@andersk @charliermarsh