-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider working incorrect when rotate View!!! #30
Comments
could you give me more details? Working incorrectly is pretty vague. What is the behavior that you see? Any video / image to follow up? |
Thanks to reply! |
Could you give me more details? From the pictures, I can see it renders correctly. what is failing? Is it slow? Also, in which OS is working differently? iOS, Android, or both? |
yes, render view is correct but when drag slider it not smooth |
@dungle27, please notice that this library is just a UI overlay on top of any player. That means that I don't control how the controls behave, that's on your end. I don't handle any video player state, I just got the props based on what the events that you use. I added more cases in the example project (PR -> #32) that may help you to debug your case. Eg, in this issue your mention that the controls don't loop. If you enable the repeat option, that means you don't need the state ENDED, as you will never reach it. Based on that, I just removed that line in the About the rotating issue, what you may do instead of rotating the components by yourself, you might change the orientation of the device. In the past I used https://github.com/yamill/react-native-orientation to change to landscape when the user taps on the fullscreen button. |
Hello!
Currently I have issue:
when rotate parent View (Video & MediaControls) use transform: [{ rotate: '90deg' }]
Slider working incorrect...
please help me fix this problem!
====================
<View style={isFullScreen ? styles.video_player : {}}>
<Video
onEnd={onEnd}
onLoad={onLoad}
onLoadStart={onLoadStart}
onProgress={onProgress}
paused={paused}
ref={ref => (videoRef.current = ref)}
resizeMode="contain"
onFullScreen={isFullScreen}
source={{ uri: mainUrl }}
repeat={true}
style={isFullScreen ? styles.video_land : styles.video_poirt}
==========================
const styles = {
video_player: { width: heightDevice - 2 * HEIGHT_STATUSBAR, height: widthDevice, transform: [{ rotate: '-90deg' }] },
video_poirt: { width: widthDevice - 6, height: (isTab ? 360 : 280) },
video_land: { width: heightDevice - 2 * HEIGHT_STATUSBAR, height: widthDevice }
}
The text was updated successfully, but these errors were encountered: