Make auth-webhook async #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwmonroe
reviewed
May 4, 2021
kwmonroe
reviewed
May 4, 2021
kwmonroe
reviewed
May 4, 2021
kwmonroe
reviewed
May 4, 2021
| return ack(req) | ||
| except Exception: | ||
| app.logger.exception('Failed to get secrets') | ||
| return nak(req) |
There was a problem hiding this comment.
❤️ nice "do not pass go" if we can't get secrets.
This converts auth-webhook from a synchronous Flask app managed by gunicorn to an asynchronous aiohttp app managed by gunicorn. This allows it to process any number of concurrent requests even if requests end up blocked or timing out on a configured external auth endpoint (keystone, custom addr, etc). Fixes: [lp:1927145][] [lp:1927145]: https://bugs.launchpad.net/charm-kubernetes-master/+bug/1927145
Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
johnsca
force-pushed
the
johnsca/lp/1927145/async-auth-webhook
branch
from
4816cb4
to
08dfce2
Compare
|
Manual test run results: |
Cache the secrets in memory and refresh them in a background task, rather than hitting the API server again on every request. Also fixes the subprocess / kubectl calls not actually being async.
|
Ready for review. For the life of me, I can't see why the lint is still failing on GH. Manual test run results: Edit: And here's the auth-webhook.log as well, for good measure. |
johnsca
force-pushed
the
johnsca/lp/1927145/async-auth-webhook
branch
from
78581b9
to
e29acd5
Compare
Apparently, I needed to recreate the tox env to update dependencies.
johnsca
force-pushed
the
johnsca/lp/1927145/async-auth-webhook
branch
from
e29acd5
to
7c4357e
Compare
|
Apparently, the lint errors were due to a slightly out-of-date tox environment, and were entirely for doc-string formattings "issues" pretty much completely unrelated to this change. That is... annoying. |
|
Updated manual integration test with latest commits. |
This was referenced May 11, 2021
|
Updated manual integration test run with latest changes. |
johnsca
added a commit
that referenced
this pull request
May 13, 2021
* Make auth-webhook async This converts auth-webhook from a synchronous Flask app managed by gunicorn to an asynchronous aiohttp app managed by gunicorn. This allows it to process any number of concurrent requests even if requests end up blocked or timing out on a configured external auth endpoint (keystone, custom addr, etc). Fixes: [lp:1927145][] [lp:1927145]: https://bugs.launchpad.net/charm-kubernetes-master/+bug/1927145 * Fix verify_ssl flag after failed cert Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Fix rendering of extra auth URLs when they are None Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Fix api_ver to be rendered as template var, not dynamic route Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Cache secrets in memory Cache the secrets in memory and refresh them in a background task, rather than hitting the API server again on every request. Also fixes the subprocess / kubectl calls not actually being async. * Improve error handling around request and config file parsing * Add test for auth load / slow custom endpoint * Fix lint errors Apparently, I needed to recreate the tox env to update dependencies. * Add retry for reading kube config to account for race between charm and webhook * Drop Flask and Werkzeug, and pin aiohttp Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
|
Backported to stable in 00e66e6 |
brettmilford
pushed a commit
to brettmilford/charm-kubernetes-master
that referenced
this pull request
May 17, 2021
* Make auth-webhook async This converts auth-webhook from a synchronous Flask app managed by gunicorn to an asynchronous aiohttp app managed by gunicorn. This allows it to process any number of concurrent requests even if requests end up blocked or timing out on a configured external auth endpoint (keystone, custom addr, etc). Fixes: [lp:1927145][] [lp:1927145]: https://bugs.launchpad.net/charm-kubernetes-master/+bug/1927145 * Fix verify_ssl flag after failed cert Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Fix rendering of extra auth URLs when they are None Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Fix api_ver to be rendered as template var, not dynamic route Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com> * Cache secrets in memory Cache the secrets in memory and refresh them in a background task, rather than hitting the API server again on every request. Also fixes the subprocess / kubectl calls not actually being async. * Improve error handling around request and config file parsing * Add test for auth load / slow custom endpoint * Fix lint errors Apparently, I needed to recreate the tox env to update dependencies. * Add retry for reading kube config to account for race between charm and webhook * Drop Flask and Werkzeug, and pin aiohttp Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts auth-webhook from a synchronous Flask app managed by gunicorn to an asynchronous aiohttp app managed by gunicorn. This allows it to process any number of concurrent requests even if requests end up blocked or timing out on a configured external auth endpoint (keystone, custom addr, etc).
Fixes: lp:1927145