revert data_changed guard on create_kubeconfig #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #33. @joedborg hit an issue where the k8s master would write kubeconfig before the kubeapi-load-balancer joined. This caused
server: $master:6443
to be written to the config file. Since we weren't checking forserver
in data_changed'sconfig_matrix
, we never re-wrote an accurate config that included the load balancer's ip.server
isn't the only problem -- we would have also missed any changes toca_crt
andclient_pass
because theconf.read()
happens before any of these changed values get written, which would make data_changed False and cause us to return early.For now, we'll keep the part of #33 that logs the write to disk (versus a more expensive
status_set
on every hook).To fully fix the spirit of https://bugs.launchpad.net/charm-kubernetes-master/+bug/1822021, we'll need to implement a helper that can compare what's on disk to what would be written to disk, and write a new config when the 2 differ.