Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 (only or dual-stack) #99

Merged
merged 9 commits into from Aug 3, 2020
Merged

Support IPv6 (only or dual-stack) #99

merged 9 commits into from Aug 3, 2020

Conversation

johnsca
Copy link
Contributor

@johnsca johnsca commented May 28, 2020

Part of lp:1881177

@johnsca
Copy link
Contributor Author

johnsca commented May 28, 2020

This hasn't been tested for IPv6-aware pods trying to talk to the K8s API server. I think we'll need to address both lp:1857173 and lp:1809379 to handle that case.

@Cynerva
Copy link
Contributor

Cynerva commented Jul 28, 2020

This hasn't been tested for IPv6-aware pods trying to talk to the K8s API server. I think we'll need to address both lp:1857173 and lp:1809379 to handle that case.

Those issues don't look relevant to me -- pods do not talk to kubeapi-load-balancer or etcd. I think it should be fine?

@johnsca
Copy link
Contributor Author

johnsca commented Jul 28, 2020

@Cynerva That comment came from the issue that came up in the original discovery which used IPv6-only for the API server endpoint (and also the service in front of it that the pods use). However, on further reflection I think that was actually an issue with the etcd endpoint being IPv6 rather than the K8s API endpoint, so I think you're correct that those are not actually an issue with the current dual-stack approach.

@when('config.changed.proxy-extra-args')
def proxy_args_changed():
clear_flag('kubernetes-master.components.started')
clear_flag('config.changed.proxy-extra-args')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes https://bugs.launchpad.net/charm-kubernetes-master/+bug/1841112. I've linked this PR to the issue and assigned you accordingly.

@Cynerva
Copy link
Contributor

Cynerva commented Aug 3, 2020

LGTM

@johnsca johnsca merged commit efe77e5 into master Aug 3, 2020
@johnsca johnsca deleted the johnsca/ipv6 branch August 3, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants