Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ResponsiveOptions type helper, add generic type to Svg#getNode method #1347

Merged
merged 1 commit into from Aug 13, 2022

Conversation

dangreen
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 13, 2022

size-limit report 📦

Path Size
dist/index.cjs 7.09 KB (0%)
dist/index.js 7.05 KB (0%)
dist/index.css 1.25 KB (0%)

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2022

Codecov Report

Merging #1347 (c1a863b) into main (4f4bb29) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          42       42           
  Lines        1231     1231           
  Branches      322      322           
=======================================
  Hits          908      908           
  Misses        239      239           
  Partials       84       84           
Impacted Files Coverage Δ
src/charts/BarChart/BarChart.ts 63.88% <ø> (ø)
src/charts/LineChart/LineChart.ts 72.72% <ø> (ø)
src/charts/PieChart/PieChart.ts 83.72% <ø> (ø)
src/core/optionsProvider.ts 33.33% <ø> (ø)
src/charts/BaseChart.ts 45.61% <100.00%> (ø)
src/svg/Svg.ts 65.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dangreen dangreen merged commit 7dd3ba2 into main Aug 13, 2022
@dangreen dangreen deleted the feat-mod-types branch August 13, 2022 14:51
Copy link
Collaborator

@gionkunz gionkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants