fix: SvgPath.parse fails on negative values #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1360 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 42 42
Lines 1231 1231
Branches 322 322
=======================================
Hits 908 908
Misses 239 239
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi there! Thanks for the PR! Would you mind adding a few tests for this case? Cheers! |
|
Hi @gionkunz! Yes, absolutely! Do you think that covers it or should I add anything else? |
gionkunz
approved these changes
Sep 27, 2022
|
Thanks, @Arantiryo , I think that's sufficient at the moment. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggested fix from #1248.