Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gruntfile more modular so it's easier to spot different tasks #39

Closed
valotas opened this issue Sep 14, 2014 · 5 comments
Closed

Make gruntfile more modular so it's easier to spot different tasks #39

valotas opened this issue Sep 14, 2014 · 5 comments

Comments

@valotas
Copy link

valotas commented Sep 14, 2014

It is all about SoC after all. Right?

Apart from that it will help a lot the newcomers to the project.

@gionkunz
Copy link
Collaborator

Please specify what you'd like to split? The site is very well separated in the current project and I like the benefit of having just one repo. Currently source/site, source/scripts/site and source/styles/site are relevant to the site. All other resources are relevant for the library.

I know it would also be nice to split it into a fully separated project. But, again, this has also a few drawbacks. For example the development pace is slower as you need to switch projects all the time and compile the library project to make use in the documentation project.

Given the clean structure with the sites folder I'd not like to go with a separate project at the moment just to keep it compact and fast paced.

Cheers

@valotas
Copy link
Author

valotas commented Sep 14, 2014

In that case just split the Gruntfile.js to server and library.

@gionkunz
Copy link
Collaborator

Why? 😄 The gruntfile is the dev part of the library. It's there to provide a development environment with live reload, linting etc. and to create the distribution package as well as the documentation site. How would you like to split the Gruntfile? The "server" tasks share many sub-tasks with the library thing. What would make sense, would be to separate the Gruntfile into much smaller files in order to structure it a bit better.

@valotas
Copy link
Author

valotas commented Sep 14, 2014

Why? Mostly because I have to go through everything there when I only care about core js stuff :)

It makes me nervous when I write javascript and find assemble hanging around :)

@gionkunz
Copy link
Collaborator

hehe 😃 Well its also nice to have a visual feedback of your javascript when you code ;-) Specially on such a visual project like this. Also assemble is responsible to create the API documentation from your javascript comments, so it's important to have feedback there too :-) I guess you need to conquer your fear 😄

I'll rename this issue to something more generic that I agree with.

Cheers

@gionkunz gionkunz changed the title Split the site project out of the main Make gruntfile more modular so it's easier to spot different tasks Sep 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants