Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip before and after draw hooks not documented and weird behaviour #10002

Closed
1 of 3 tasks
LeeLenaleee opened this issue Dec 17, 2021 · 1 comment · Fixed by #10276
Closed
1 of 3 tasks

Tooltip before and after draw hooks not documented and weird behaviour #10002

LeeLenaleee opened this issue Dec 17, 2021 · 1 comment · Fixed by #10276

Comments

@LeeLenaleee
Copy link
Collaborator

Documentation Is:

  • Missing or needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

The tooltip plugin calls the following plugin hooks: beforeTooltipDraw and afterTooltipDraw. These don't seem to be documentated.

Also it seems like the hook are called in the wrong place because it seems they get called every render cycle. But changing this will make it a braking change.

Your Proposal for Changes

Document the plugin hooks.

Change the hooks to only fire when the tooltip is actually being draw instead of every render cycle

Example

https://codepen.io/leelenaleee/pen/ZEXKRmR

@mssrmaps
Copy link

Thanks for adding this as a milestone. I am currently monitoring other lifecycle triggers and watching the chart context for changes in the tooltip. It would be more logical to trigger when the tooltip notifies the chart of changes directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants