-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package size is more than 20 MB #10835
Comments
I don't think publishing the docs was intentional. It was likely something that happened during the npm -> pnpm switch |
This is an interesting one, if I do a dry run it only packages the dist helpers and auto folder as specified here in the Lines 45 to 49 in ae1a720
|
@LeeLenaleee what node/npm versions do you have? Since this came at 3.9.0, it could be that node version update that caused us to have to release 3.9.1 |
I think the building of docs, that is done in the CI will, output those in Chart.js/docs/.vuepress/config.ts Line 13 in 8a29eba
Chart.js/.github/workflows/release.yml Lines 42 to 43 in 8a29eba
And it was changed here: |
But only the extension changed there, seems kind of weird that that causes the docs to be included. |
in package.json "dist/*.js",
"dist/chunks/*.js", was changed to "dist/**", |
Expected behavior
Package size should be -+ like the previous version
Current behavior
It seems that after the release of version 3.9.0 the package size grew up enormously.
![image](https://user-images.githubusercontent.com/13430395/198243836-f0096dac-97d3-4d42-99cd-0ea708a836b2.png)
You can see it here:
I looked into it and it seems that you are publishing the docs as well.
Not sure if it's a mistake or on propose
Reproducible sample
master
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
v3.9.0
Browser name and version
No response
Link to your project
No response
The text was updated successfully, but these errors were encountered: