Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbind instance config from chart type #10963

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: unbind instance config from chart type #10963

merged 1 commit into from
Dec 16, 2022

Conversation

dangreen
Copy link
Collaborator

Fixes #10865

Chart and datasets types can be changed in runtime, but types restrict it. In this PR, I unbound the instance's config from the initial chart type.

Here is an example: https://stackblitz.com/edit/typescript-7g6pc8?file=index.ts

The code works, but TS prints errors.

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 12, 2022
@LeeLenaleee LeeLenaleee added this to the Version 4.1 milestone Dec 12, 2022
@dangreen
Copy link
Collaborator Author

@LeeLenaleee @etimberg @kurkle review please 🙏

@kurkle
Copy link
Member

kurkle commented Dec 15, 2022

I'm probably not considering the full impact of this, but then again if it passes tests, it should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'type' does not exist on type 'ChartConfigurationCustomTypesPerDataset'
4 participants