Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border width is not counted as part of ArcElement #11178

Closed
stockiNail opened this issue Mar 6, 2023 · 0 comments · Fixed by #11180
Closed

Border width is not counted as part of ArcElement #11178

stockiNail opened this issue Mar 6, 2023 · 0 comments · Fixed by #11180

Comments

@stockiNail
Copy link
Contributor

Feature Proposal

Currently, when you set a borderWidth to an arc element, the width of the border is ignored by ArcElement when inRange method is invoked.
When a lineWidth is set before drawing on the canvas, half with is part of the shape itself but half width is drawn outside the shape.
In my opinion, but correct me if I'm wrong, the border width should be take in consideration as part of the element.

Codepen: https://codepen.io/stockinail/pen/VwGzWZN

If you move the mouse, hovering the pie chart, you can see that the border will appear when the mouse point is in the middle of the border.

Possible Implementation

I havent seen the arc element code yet, therefore I can only write now, it should be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant