Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas fallback #2807

Closed
yonatoshi opened this issue Jun 19, 2016 · 3 comments
Closed

Canvas fallback #2807

yonatoshi opened this issue Jun 19, 2016 · 3 comments

Comments

@yonatoshi
Copy link

If someone doesn't have canvas enabled there is JavaScript errors which can cause other working scripts not to work. With the rise of canvas blocking it would be nice if chart Js had some fallback or even a way to alert the user canvas is disabled. The reason canvas blocking is increasing is because it can be fingerprinted by browsers and is a privacy issue for some users. Thanks for the great library and hope you can consider.

@etimberg
Copy link
Member

I agree that we should gracefully handle this condition. I am happy to merge a PR that prevents a crash when the canvas does not exist.

@etimberg etimberg added this to the Version 2.4 milestone Sep 25, 2016
@simonbrunel
Copy link
Member

@yonatoshi old post, but can you give more details about the JS errors and the way to disable canvas? what kind of fallback / alert are you thinking of?

@etimberg
Copy link
Member

Fixed in #3474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants