Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCanvas fallback #2807
Closed
Canvas fallback #2807
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
I agree that we should gracefully handle this condition. I am happy to merge a PR that prevents a crash when the canvas does not exist. |
This comment has been minimized.
This comment has been minimized.
|
@yonatoshi old post, but can you give more details about the JS errors and the way to disable canvas? what kind of fallback / alert are you thinking of? |
This comment has been minimized.
This comment has been minimized.
|
Fixed in #3474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If someone doesn't have canvas enabled there is JavaScript errors which can cause other working scripts not to work. With the rise of canvas blocking it would be nice if chart Js had some fallback or even a way to alert the user canvas is disabled. The reason canvas blocking is increasing is because it can be fingerprinted by browsers and is a privacy issue for some users. Thanks for the great library and hope you can consider.