Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Destruction error #3561

Closed
charsleysa opened this issue Nov 7, 2016 · 4 comments
Closed

[BUG] Destruction error #3561

charsleysa opened this issue Nov 7, 2016 · 4 comments
Assignees
Milestone

Comments

@charsleysa
Copy link

charsleysa commented Nov 7, 2016

Expected Behavior

Chart should be successfully destroyed.

Current Behavior

Chart throws error during destruction.

Possible Solution

Error is thrown on this line with the context being undefined.
Issue is caused on this line due the context being set to undefined

Steps to Reproduce (for bugs)

  1. Create a Chart
  2. Destroy the chart calling .destroy()

Context

For SPA this can cause issues with state corruption.

Environment

  • Chart.js version: 2.4.0 (latest master)
  • Browser name and version: Chrome 54
  • Link to your project: JSBin
@charsleysa charsleysa changed the title Destruction bug [BUG] Destruction error Nov 7, 2016
@etimberg
Copy link
Member

etimberg commented Nov 7, 2016

@charsleysa which version of 2.4 are you using? the latest from master?

@etimberg
Copy link
Member

etimberg commented Nov 7, 2016

Also, do you have a test case that can reproduce this?

@charsleysa
Copy link
Author

@etimberg the issue only occurs on high density screen (such as the Surface Pro 4 screen).
I've added a link to a JSBin which recreates this issue.
I am using the latest from master.

@simonbrunel
Copy link
Member

Introduced by that PR, I will fix it for 2.4. Thank you @charsleysa for reporting this issue before we release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants