Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print issue #5039

Closed
mcconnrs opened this issue Dec 11, 2017 · 2 comments
Closed

Print issue #5039

mcconnrs opened this issue Dec 11, 2017 · 2 comments

Comments

@mcconnrs
Copy link

I was having issues with printing and found #1350 . There was a suggestion added after it was closed that fixes the issue. Could Tim's fix be incorporated into a future release?

@etimberg
Copy link
Member

@mcconnrs I don't think we should be modifying the global before print hook. I'm happy to merge an update to the docs

@alexfmpe
Copy link

For some reason, resizing on window.onbeforeprint like the docs say didn't fix it for me (on none of several browsers and OSes), but using window.matchMedia as recommended in #1350 (comment)) worked flawlessly.
Maybe it'd be worth it to have each chart add a media query listener to resize it on print ? Seems much less invasive than modifying onbeforeprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants