Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time format deprecated issue #6980

Closed
rashearth opened this issue Jan 18, 2020 · 7 comments · Fixed by #8781
Closed

time format deprecated issue #6980

rashearth opened this issue Jan 18, 2020 · 7 comments · Fixed by #8781
Labels
type: bug version: 2

Comments

@rashearth
Copy link

Hi, i would like to reopen the issue thats going on in this thread.
#6677

i found out that these warning pops out every 10milisec? when i use the below plugins.

【warnings poping out】

time scale: "time.format" is deprecated. Please use "time.parser" instead

72200621-0958be80-348f-11ea-8a81-34ebb4f74741

since it pops out in high rate, the memory will be decreased, leading huge lag.

【plugins that makes warning】
①chart.js 2.9.3
②chart.js financial plugin
③chart.js streaming plugin 1.8.0

I have made a quick sample html here.
http://aifx2.sakura.ne.jp/realtimecharttest2.html

please kindly confirm.

<!DOCTYPE HTML>
<html>
 <head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no">
	
	

<head>
	<script src="https://cdn.jsdelivr.net/npm/moment@2.24.0/min/moment.min.js"></script>
	<script src="https://cdn.jsdelivr.net/npm/chart.js@2.9.3"></script>
	<script src="https://www.chartjs.org/chartjs-chart-financial/chartjs-chart-financial.js"></script>
	<script src="https://cdn.jsdelivr.net/npm/chartjs-plugin-streaming@1.8.0"></script>
</head>
<body>
	<div>
		<canvas id="myChart"></canvas>
	</div>
</body>


<script>

 var past =  {t:Date.now()-20000, o:87, h: 101, l: 78, c: 100};
 var past2 = {t:Date.now()-40000, o:87, h: 101, l: 78, c: 100}
 console.log(past);
var ask = Math.random();
 

setInterval(function () {
	
	annotationx= Date.now();

	annotationy = 90;
	return annotationx;
	return annotationy; 
	
	
}, 10000); 





function onRefresh(chart) {
	var t = Date.now();
	var data2 = chart.data.datasets[0].data;
	var last;

	t -= t % 1000;
	if (data2.length === 0) {
		data2.push(past);
		data2.push(past2);
	}
	last = data2[data2.length - 1];
	if (t != last.t) {
		var c = last.c;
		last = { t: t, o: c, h: c, l: c, c: c };
		data2.push(last);
	}
	last.c += Math.random() - 0.5;
	last.h = Math.max(last.h, last.c);
	last.l = Math.min(last.l, last.c);





}

var config = {
	type: 'candlestick',
	data: {
		datasets: [
{
			data: [],
			fractionalDigitsCount: 2
		},
             




]
	},
	options: {


		title: {
			display: true,
			text: 'Financial chart sample'
		},
		legend: {
			display: false,
		},
		scales: {
			xAxes: [{
				type: 'realtime',
				realtime: {
					duration: 120000,
					refresh: 100,
					delay: 0,
					onRefresh: onRefresh
				}
			}]
		},
		tooltips: {
			position: 'nearest',
			intersect: false
		},
		animation: {
			duration: 0
		}
	}
};

window.onload = function() {
	var ctx = document.getElementById('myChart').getContext('2d');
	window.myChart = new Chart(ctx, config);
};


</script>
@benmccann
Copy link
Contributor

@rashearth would you be able to change your example so that it uses the non-minified version of Chart.js (https://cdn.jsdelivr.net/npm/chart.js@2.9.3/dist/Chart.js)? Otherwise it's not possible to debug and understand what is happening.

@benmccann
Copy link
Contributor

It looks to me like perhaps the issue is the warning is printed when the option is not undefined, but the default value is false

This issue has been fixed for 3.0. I'm unsure as to whether we would fix it for 2.9 since we're focused on 3.0 right now

@rashearth
Copy link
Author

sure, i have changed the to nonminified version
(https://cdn.jsdelivr.net/npm/chart.js@2.9.3/dist/Chart.js)

thx for the considering

@kurkle
Copy link
Member

kurkle commented Feb 17, 2020

I think you can work around this by setting the time.format to undefined.

@ptone
Copy link

ptone commented Mar 11, 2020

FWIW - this fixed this issue for me, along with a bad stutter in animation. This was with using the chart.js streaming plugin 1.8.0 (maybe this should be raised on that project too/instead?)

This issue only happened with using chartjs as an NPM module and rollup, but did not happen when using chartjs via head include.

@Spongman
Copy link

this should be fixed.

@stephen-golban
Copy link

stephen-golban commented Aug 6, 2020 •
edited

Hey, i found the solution, just change the time.format to time.parser and it will fix your issue, I mean from the chart JS options where it is
type: "time",
time: {
format: "MM/DD/YY",
tooltipFormat: "ll",
},
change the bold word "format" to parser and that's it.

@etimberg etimberg mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug version: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3.0.0 version bump etimberg/Chart.js
7 participants
@ptone @benmccann @Spongman @etimberg @rashearth @kurkle @stephen-golban