Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Charts are Laggy in Firefox since Version 2.8.0 #7682

Closed
2 of 3 tasks
ThatIsAPseudo opened this issue Jul 29, 2020 · 5 comments
Closed
2 of 3 tasks

Sample Charts are Laggy in Firefox since Version 2.8.0 #7682

ThatIsAPseudo opened this issue Jul 29, 2020 · 5 comments

Comments

@ThatIsAPseudo
Copy link

ThatIsAPseudo commented Jul 29, 2020

Documentation Is:

  • Missing or needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

I did not understand why the documentation's examples were really smooth and responsive whereas my own code was laggy and slow.
Turns out 2.8 and above slows down (my?) charts (I may fill another issue for this), and despite the tag latest in the documentation's url (www.chartjs.org/docs/latest/charts/doughnut.html), some examples seem to still use an older version.

(But it looks like the Samples use a more recent version since they are slower.)

Your Proposal for Changes

Examples should all be using the version of Chartjs tagged in the URL to avoid confusion.

Example

Samples :

Documentation :

Edit: I used Firefox; with Chrome it's much less "laggy", so the difference isn't really noticeable.

@etimberg
Copy link
Member

@ThatIsAPseudo do you see similar lag in v3 alpha? https://www.chartjs.org/samples/master/charts/pie.html

@ThatIsAPseudo
Copy link
Author

@etimberg Yes, v3 is slow as well.

@etimberg etimberg changed the title Documentation's examples use an old Chartjs version Sample Charts are Laggy in Firefox since Version 2.8.0 Oct 1, 2020
@kurkle
Copy link
Member

kurkle commented Oct 16, 2020

For v2, the docs use gitbook and chartjs is injected through plugin.
It looks like the plugin uses chart.js v2.5.0.

In v3 we moved away from gitbook, so it does not really make sense to update the gitbook plugin anymore.

May I ask what kind of environment are you using to detect the lag?

latest
image
2.7.0
image
master
image

All using chrome, because its easy to do the benchmark in that.

So that would suggest that v2.7.0 is actually the slowest one.

There have been some improvement on the border drawing, so there is a little bit more computing in later versions. But it is really insignificant at least in the ways I can measure it.

@ThatIsAPseudo
Copy link
Author

Well, I just tried to replicate the issue but everything seems to be working well. I don't know if changes were made but the example I pointed out as laggy (https://www.chartjs.org/samples/latest/charts/pie.html) is smooth now.

@kurkle
Copy link
Member

kurkle commented Oct 16, 2020

Closing as not reproducible. Please reopen, if you find a way.

@kurkle kurkle closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants