-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented (and maybe unwanted) breaking changes in 3.0.0-beta.11 #8470
Comments
label: context => context.dataset.label + ': ' + formatNumber(context.dataPoint.y) |
Thanks @LeeLenaleee. I updated the release notes and PR to correctly tag it as a change. |
Thanks. |
I will look into improving |
You of course know much better about the library than I do, and thus probably have a good rationale for the choice of the name |
The reason we called it If we get lots of feedback on the discoverability of it, I'm happy to alias back to the old name as well. It's a pretty lightweight change. |
Ok, so I did some research. The format changes for radar/polar area/doughnut charts. Bar / Line Chartsparsed: { x: number; y: number } Bubble chartsparsed: { x: number; y: number, _custom: number } Radar / Polar Area Chartsparsed: { r: number } Pie / Doughnut Chartsparsed: number Possible SolutionI'd like to get some opinions on this proposal to fix it.
Assuming there are no implementation hiccups, I think this would work and correctly type it. |
To me that sounds good. |
Also note that float bars have a item._custom = {
barStart,
barEnd,
start: startValue,
end: endValue,
min,
max
}; |
Expected Behavior
These lines of Typescript code, which compiled fine in 3.0.0-beta.10, should also compile in beta.11 (I haven't found any documented breaking change documenting those):
Current Behavior
They don't compile anymore.
Possible Solution
I've had to change them to
The text was updated successfully, but these errors were encountered: