Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on docs version select #8880

Closed
jackisherwood opened this issue Apr 10, 2021 · 4 comments · Fixed by #8882
Closed

404 on docs version select #8880

jackisherwood opened this issue Apr 10, 2021 · 4 comments · Fixed by #8882

Comments

@jackisherwood
Copy link

Expected Behavior

Selecting a version at the top of the page here should route the user to the selected version.

Current Behavior

Routed to 404 page.

Possible Solution

Appears to be due to the base variable in /docs/.vuepress/config.js.
In dev, this variable is an empty string and works correctly

Steps to Reproduce

Go here
Select 2.9.4 from version select

Context

Environment

  • Chart.js version:
  • Browser name and version:
  • Link to your project:
@simonbrunel
Copy link
Member

@kurkle it should be fixed by simonbrunel/vuepress-plugin-versions@4a4cb5a. Can you check if it works with the Chart.js docs so I can release it?

@kurkle
Copy link
Member

kurkle commented Apr 11, 2021

Will take a look later today, but not for several hours

@etimberg
Copy link
Member

etimberg commented Apr 11, 2021

I tested locally using commit 4a4cb5acaf328ac7397a70d3ae0cc41497763a6b.

I ran the docs locally with the base URL set to /docs/VERSION and the links appear correct. In the image below I was hovering over the 3.0.2 link

doc link

@simonbrunel
Copy link
Member

simonbrunel/vuepress-plugin-versions@v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants