Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number, null and undefined as valid return types #8891

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves #8890

@etimberg etimberg added the type: types Typescript type changes label Apr 13, 2021
@kurkle
Copy link
Member

kurkle commented Apr 13, 2021

Just one question, why number? Its a label afterall.

@LeeLenaleee
Copy link
Collaborator Author

Because you can return a number, tried it by returning double the value for the y axes, just to test it out, so I dont know of any valid use case atm where you would want to return only a number to it but it takes it as an input

@kurkle kurkle merged commit f76ca01 into chartjs:master Apr 13, 2021
@LeeLenaleee LeeLenaleee deleted the update/types-tick-callback branch April 13, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TickOptions callback don't allow return null or undefined
3 participants