Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning undefined/null in the tick callback doesnt hide gridLine anymore #8892

Closed
LeeLenaleee opened this issue Apr 13, 2021 · 0 comments · Fixed by #8914
Closed

Returning undefined/null in the tick callback doesnt hide gridLine anymore #8892

LeeLenaleee opened this issue Apr 13, 2021 · 0 comments · Fixed by #8914
Labels
type: bug
Milestone
Version 3.1.1

Comments

@LeeLenaleee
Copy link
Collaborator

Expected Behavior

When returning null or undefined the tick text and the gridline should not show.

Current Behavior

The null or undefined gets converted to text and still shows the gridline

Possible Solution

Steps to Reproduce

https://jsfiddle.net/Leelenaleee/2takrsw9/6/
Problem goes as far back as the first beta of V3, in the first beta.

Context

Came across this when updating types from #8890

Environment

  • Chart.js version: 3.1.0
  • Browser name and version:
  • Link to your project:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.1.1
Development

Successfully merging a pull request may close this issue.

Skip ticks by callback value as documented kurkle/Chart.js
2 participants
@kurkle @LeeLenaleee