Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type declaration for Decimation plugin #9162

Closed
tipy01 opened this issue May 26, 2021 · 0 comments · Fixed by #9172
Closed

Missing type declaration for Decimation plugin #9162

tipy01 opened this issue May 26, 2021 · 0 comments · Fixed by #9172
Labels
type: bug type: types Typescript type changes
Milestone
Version 3.3.1

Comments

@tipy01
Copy link

tipy01 commented May 26, 2021

Expected Behavior

Find the Decimation plugin in typescript type for registering.

Current Behavior

Module '"chart.js"' has no exported member 'Decimation'.ts(2305)

Possible Solution

Add
export const Decimation: Plugin;

in types/index.esm.d.ts

Steps to Reproduce

With the code in

https://www.chartjs.org/docs/3.3.0/getting-started/integration.html#bundlers-webpack-rollup-etc

only the non-short form that includes Decimation

Context

I use Typescript

Environment

  • Chart.js version:"chart.js": "^3.3.0"
    "ts-loader": "^9.2.2",
    "typescript": "^4.2.4",
    "webpack": "^5.37.1",
@kurkle kurkle added the type: types Typescript type changes label May 28, 2021
@kurkle kurkle mentioned this issue May 28, 2021
Merged
@etimberg etimberg added this to the Version 3.3.1 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug type: types Typescript type changes
Projects
None yet
Milestone
Version 3.3.1
Development

Successfully merging a pull request may close this issue.

Add declaration for Decimation plugin kurkle/Chart.js
3 participants
@etimberg @kurkle @tipy01