Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify + common-shakeify + Chart.js = infinite stack trace #11479

Closed
ile opened this issue Aug 30, 2023 · 1 comment
Closed

Browserify + common-shakeify + Chart.js = infinite stack trace #11479

ile opened this issue Aug 30, 2023 · 1 comment

Comments

@ile
Copy link

ile commented Aug 30, 2023

Expected behavior

I'm using browserify@17.0.0 + common-shakeify@1.1.2 + chart.js@4.4.0.

In JavaScript I have this:

const Chart = require('chart.js/auto');

console.log('Hello');

Bundling will give me a stack trace and a crash.

Current behavior

ile@ilepc:~/src/sc2/browserify-chartjs$ ./run.sh 
/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417
            var ref = new _reference2.default(node, this, assign || _reference2.default.READ, writeExpr, maybeImplicitGlobal, !!partial, !!init);
                      ^

RangeError: Maximum call stack size exceeded
    at ClassScope.__referencing (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417:23)
    at Referencer.Identifier (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/referencer.js:425:33)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:104:34)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)

Node.js v20.5.1

Reproducible sample

https://github.com/ile/browserify-chartjs

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

No response

chart.js version

v4.4.0

Browser name and version

No response

Link to your project

https://github.com/ile/browserify-chartjs

@ile ile added the type: bug label Aug 30, 2023
@ile ile changed the title Browserify + Chart.js = infinite stack trace Browserify + common-shakeify + Chart.js = infinite stack trace Aug 30, 2023
@ile
Copy link
Author

ile commented Sep 17, 2023

This wasn't a bug in Chart.js, but browserify couldn't handle the es2022 syntax. It could handle es2021. Closing.

@ile ile closed this as completed Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant