Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chart "locale" if it is not specified in the adatpter options #72

Merged
merged 5 commits into from Aug 3, 2022
Merged

Use chart "locale" if it is not specified in the adatpter options #72

merged 5 commits into from Aug 3, 2022

Conversation

stockiNail
Copy link
Contributor

@stockiNail stockiNail commented Jul 30, 2022 •
edited

Fix #71
Answer to comment #46 (comment)

Missing

  • Release new CHART.JS version
  • Add test cases using chart locale.
  • Add doc in the README

@stockiNail stockiNail marked this pull request as draft July 30, 2022 16:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2766431625

  • -2 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.7%) to 91.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 0 2 0.0%
Totals Coverage Status
Change from base Build 2736928659: -6.7%
Covered Lines: 31
Relevant Lines: 33
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2766431625

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.7%) to 91.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 0 2 0.0%
Totals Coverage Status
Change from base Build 2736928659: -6.7%
Covered Lines: 31
Relevant Lines: 33
💛 - Coveralls

@LeeLenaleee
Copy link
Contributor

@stockiNail chart.js v3.9 has been released with the necessary changes

@stockiNail
Copy link
Contributor Author

stockiNail commented Aug 2, 2022 •
edited

Thank you @LeeLenaleee. I need to finish a couple of other things for another project and then I'll take care.

@LeeLenaleee
Copy link
Contributor

Yeah no problem, no hurry, just wanted to let you know :)

@stockiNail stockiNail marked this pull request as ready for review August 2, 2022 14:01
@stockiNail
Copy link
Contributor Author

Yeah no problem, no hurry, just wanted to let you know :)

Ready for review! Thank you!

LeeLenaleee
LeeLenaleee reviewed Aug 2, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@stockiNail @LeeLenaleee
Update README.md
ba02b63 
Co-authored-by: Jacco van den Berg <jaccoberg2281@gmail.com>
@kurkle kurkle merged commit 2f68ace into chartjs:master Aug 3, 2022
@kurkle
Copy link
Member

kurkle commented Aug 3, 2022

@stockiNail can you submit a version bump?

@kurkle kurkle added this to the 1.2.0 milestone Aug 3, 2022
@stockiNail
Copy link
Contributor Author

@stockiNail can you submit a version bump?

Yes, give some minutes

@stockiNail stockiNail deleted the newInit branch August 3, 2022 17:02
@stockiNail
Copy link
Contributor Author

@stockiNail can you submit a version bump?

@kurkle done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Use chart "locale" if it is not specified in the adatpter options
4 participants
@stockiNail @coveralls @LeeLenaleee @kurkle