Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden label when using position: "top" on vertical line label #55

Closed
buejoh opened this issue Jan 23, 2017 · 1 comment
Closed

Hidden label when using position: "top" on vertical line label #55

buejoh opened this issue Jan 23, 2017 · 1 comment
Labels

Comments

@buejoh
Copy link
Contributor

buejoh commented Jan 23, 2017

Version: 0.5.3

Using position: "top" results in a hidden label when using vertical line annotation.

Changing line 852 in the source code from

ret.x = (isFinite(line.m) ? line.getY(ret.y) : view.x1) - xa;

to

ret.x = (isFinite(line.m) ? line.getX(ret.y) : view.x1) - xa;

fixes this issue. Maybe just a typo?

@compwright compwright added the bug label Jan 23, 2017
@compwright
Copy link
Collaborator

I believe so, yes. Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants