Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: add typings for typescript support #28

Closed
mattmeye opened this issue Jan 16, 2018 · 3 comments
Closed

feature-request: add typings for typescript support #28

mattmeye opened this issue Jan 16, 2018 · 3 comments

Comments

@mattmeye
Copy link

see http://definitelytyped.org/

@pkopac
Copy link
Contributor

pkopac commented Mar 13, 2018

Hi @mattmeye! Thank you for the suggestion. We haven't planned that previously and since this is not a bug report, I can't promise when/if it will be done. We would gladly accept a PR, though, if you happen to have done it for your needs already.

@hassansin
Copy link
Contributor

@mattmeye you can now find the defintions at https://www.npmjs.com/package/@types/chartmogul-node. Please let us know if you face any issue using it.

@okhomenko
Copy link

@types/chartmogul-node are outdated. Miss-match right of the bat @types/chartmogul-node

export class Config {
    VERSION: string;
    API_BASE: string;
    retries: number;

    constructor(token: string, secret: string, base?: string);
    getAccountToken(): string;
    getSecretKey(): string;
}

vs chartmogul-node

class Config {
  constructor (apiKey, apiBase) {
    this.apiKey = apiKey;
    this.apiBase = apiBase || API_BASE;
  }
[Nest] 87015  - 03/12/2022, 6:08:58 AM   ERROR [ExceptionsHandler] Invalid URI "abcd12312312312312apikey/v1/ping"
Error: Invalid URI "abcd12312312312312apikey/v1/ping"
    at Request.init (/Users/okhomenko/chartmogul-integration/node_modules/request/request.js:273:31)
    at new Request (/Users/okhomenko/chartmogul-integration/node_modules/request/request.js:127:8)
    at request (/Users/okhomenko/chartmogul-integration/node_modules/request/index.js:53:10)
    at RetryOperation._fn (/Users/okhomenko/chartmogul-integration/node_modules/chartmogul-node/lib/chartmogul/util/retry.js:46:5)
    at RetryOperation.attempt (/Users/okhomenko/chartmogul-integration/node_modules/retry/lib/retry_operation.js:112:8)
    at Object.retryRequest (/Users/okhomenko/chartmogul-integration/node_modules/chartmogul-node/lib/chartmogul/util/retry.js:45:13)
    at /Users/okhomenko/chartmogul-integration/node_modules/chartmogul-node/lib/chartmogul/resource.js:68:12
    at new Promise (<anonymous>)
    at Function.request (/Users/okhomenko/chartmogul-integration/node_modules/chartmogul-node/lib/chartmogul/resource.js:40:21)
    at Function.ping (/Users/okhomenko/chartmogul-integration/node_modules/chartmogul-node/lib/chartmogul/resource.js:145:19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants