Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten: Override NO_FILESYSTEM=1 #64

Open
dasa opened this issue Jan 18, 2017 · 1 comment
Open

Emscripten: Override NO_FILESYSTEM=1 #64

dasa opened this issue Jan 18, 2017 · 1 comment

Comments

@dasa
Copy link
Contributor

dasa commented Jan 18, 2017

I'm getting this warning in my build: warning: unresolved symbol: $FS

This goes away if I comment out this line:
https://github.com/charto/nbind/blob/master/src/nbind.gypi#L35

Is there a better way to remove this or maybe it should be removed from src/nbind.gypi since it seems that Emscripten should remove it when needed:
http://kripken.github.io/emscripten-site/docs/optimizing/Optimizing-Code.html?highlight=no_filesystem#miscellaneous-code-size-tips

@jjrv
Copy link
Member

jjrv commented Jan 18, 2017

I'll try to release version 0.4.0 soon, where the .gypi file will be stored inside your project instead of under node_modules/nbind. This should make it easier to customize the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants