-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't compile with latest Visual Studio 2017 update #98
Comments
Nice... That's clearly a new compiler bug. Try commenting that line out, does it work then? It's checking if some input parameters are valid and can be omitted if your JavaScript side code is correct anyway. Then I can rewrite that line differently. However if there's other new compiler crashes all over the place, that will be a different matter. |
Commenting out the line didn't generate further compiler issues |
OK, thanks for reporting! I'll install the latest VS Community edition so the bug would hopefully appear here, and then try to figure out an alternative way to write that line. Until then, at least locally you can use the commented out version. |
Hi, Any updates on fixing this issue? We would really like a fix soon as this is preventing us from moving to VS 2017. |
Sorry about the delay. 0.3.15 is out now and at least on my machine, the compiler internal error is fixed. |
With VS Update 15.5.2, existing project using nbind stopped compiling.
\nbind\include\nbind\v8/Caller.h(68): fatal error C1001: An internal error has occurred in the compiler.
The text was updated successfully, but these errors were encountered: