Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short names of countries in i18n.ts #8

Closed
chase0213 opened this issue Jan 21, 2019 · 0 comments
Closed

Fix short names of countries in i18n.ts #8

chase0213 opened this issue Jan 21, 2019 · 0 comments
Assignees
Milestone

Comments

@chase0213
Copy link
Owner

Bug, feature request, or proposal:

proposal

What is the expected behavior?

export const I18n = {
  enUS: {
    dayOfWeek: {
      default: [
...

What is the current behavior?

export const I18n = {
  en: {
    dayOfWeek: {
      default: [
...

What are the steps to reproduce?

See https://github.com/chase0213/ng-infinite-calendar/blob/master/src/i18n.ts

What is the use-case or motivation for changing an existing behavior?

en is ambiguous because enUS, enGB and more exist.

Which versions of package, node, npm or other packages are affected?

0.1.4

Is there anything else we should know?

nothing

@chase0213 chase0213 self-assigned this Jan 21, 2019
@chase0213 chase0213 changed the title Fix short names of countries in i18n Fix short names of countries in i18n.ts Jan 21, 2019
@chase0213 chase0213 added this to the v0.1.5 milestone Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant