New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking downloading #13

Closed

SoundBlaster opened this issue Feb 5, 2015 · 0 comments

SoundBlaster commented Feb 5, 2015

Please fix two methods or add new one

(BOOL)isFileDownloadingForUrl:(NSString *)fileIdentifier
withProgressBlock:(void(^)(CGFloat progress))block;
(BOOL)isFileDownloadingForUrl:(NSString *)fileIdentifier
withProgressBlock:(void(^)(CGFloat progress))block
completionBlock:(void(^)(BOOL completed))completionBlock;

They replace download's blocks if arguments are NULL - it's bad behaviour.
Or please add new method

(BOOL)isFileDownloadingForUrl:(NSString *)fileIdentifier
{
BOOL retValue = NO;
TWRDownloadObject *download = [self.downloads objectForKey:fileIdentifier];
if (download) {
retValue = YES;
}
return retValue;
}

chasseurmic closed this as completed in

bb0a940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment