it seems RECALLED: 10002 message dose't trigger on('message') event

[JasLin]

i tested the ding-dong-bot and recalled some message , it dose not trigger the event.

[huan]

Hi JasLin,

when you run ding-dong-bot, there should be a scan event first, with the login qrcode url that you need to scan to login.

the message event will be emitted after login, at the time when you receive a new message.

[JasLin]

@zixia thanks for your reply , actually , i have used wechaty in my programs. i write a robot to serve some business, and everything is ok , but the when i recalled message from my wechat in mobile, it never trigger the message event . the test code is simple:

...
.on('message', m => {
  m.ready()
  .then(msg => {
    log.info('Bot', 'recv: %s', msg.toStringEx())
    logToFile(JSON.stringify(msg.rawObj))
    // test recalled message
    if(msg.type() === Message.Type.RECALLED){
        console.log('recalled a message')
        msg.dumpRaw()
    }
    ...

  })
  .catch(e => log.error('Bot', 'ready: %s' , e))
})

there is no message received after recalled some messages from mobile.

BTW: thanks for wechaty again, it may be the best wecaht sdk i have seen in github. i had move my code from python to javascript after compare with wechaty and some python wechat sdk .

[hexsum]

it may be the best wecaht sdk i have seen in github

相当高的评价，我也赞一个

[huan]

@JasLin confirmed.

It seems the message of type RECALLED is not triggered in the current hook process.

It must has other hook point of this type of message, will figure it out when I have time.

also, thanks for your favorable comment! I'd like to write it to README :) and thanks @sjdy521, too!

[huan]

@JasLin do u have any idea of how to fix this issue? i'm going to review it next week.

[JasLin]

@zixia i haven't dig into this issue yet, this issue not so harmfull ,or i will going to see this next week too.

[huan]

About the RECALLED Message behavior of webwxApp:

Problem

1. RECALLED Message will not be processed like other messages:

   https://github.com/wechaty/webwx-app-tracker/blob/06ba28a762e4f13d1710962577afb53017d2190f/formatted/webwxApp.js#L2007

2. It do return instead of call addChatMessage():

   https://github.com/wechaty/webwx-app-tracker/blob/06ba28a762e4f13d1710962577afb53017d2190f/formatted/webwxApp.js#L2034

3. So there will no message:add:success broadcast event fired for any RECALL Message:

   https://github.com/wechaty/webwx-app-tracker/blob/06ba28a762e4f13d1710962577afb53017d2190f/formatted/webwxApp.js#L1930

4. At last Wechaty will never get it.

Solution

We need to add addChatMessage() call to process a RECALLED message.

1. wrap _recalledMsgProcess()

   https://github.com/wechaty/webwx-app-tracker/blob/06ba28a762e4f13d1710962577afb53017d2190f/formatted/webwxApp.js#L2007

2. wrap messageProcess()

   https://github.com/wechaty/webwx-app-tracker/blob/06ba28a762e4f13d1710962577afb53017d2190f/formatted/webwxApp.js#L1971

3. any other good idea/suggestion/brainstorming?

TBD

See Also

1. Prevent Recalling Messages (Prototype): arrowrowe/electronic-wechat@3126eee

[zhaozhiming]

Do the solutions above have not help?

[huan]

Close this issue because the PR will be merged soon.