Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing fastwarc via pip install fails if compilation is required or requested #16

Closed
sebastian-nagel opened this issue Nov 26, 2021 · 3 comments

Comments

@sebastian-nagel
Copy link
Contributor

  • applies to fastwarc 0.6.6 and 0.7.0 (0.6.5 successfully installed)
  • seen on Ubuntu 20.04 and 21.04
  • on amd64 with pip3 install --no-binary fastwarc fastwarc
  • or on aarch64 with pip3 install fastwarc (no binaries provided for ARM CPUs)

The error message indicates that fastwarc is now too interconnected with resiliparse

  ERROR: Command errored out with exit status 1:
...  
  from resiliparse_common.string_util cimport str_to_lower, strip_str, strip_c_str
  ^
  ------------------------------------------------------------
  
  fastwarc/warc.pyx:32:0: 'resiliparse_common/string_util.pxd' not found

Building from a checkout of chatnoir-resiliparse via pip3 wheel -e fastwarc succeeds also on ARM-based systems.

@phoerious
Copy link
Member

resiliparse_common is a directory that's copied into the source build of both packages. I guess I forgot to add it the the package data. I'll fix that. In the meantime, compiling from the repository should work.

@phoerious
Copy link
Member

Fixed in 5b43781. Builds are underway.

@sebastian-nagel
Copy link
Contributor Author

Thanks, @phoerious: confirmed - installation with compilation works for 0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants