-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnKeyDown event occurs twice when typing in Korean and then hitting enter #9
Comments
@HwangTaehyun Thanks for PR. I will reproduce this bug before merging, and check if everything works for other edge cases as well. |
I checked again, and it works fine in Chrome on Windows, and it seems that this problem occurs in Chrome on Mac. Please note. Thank you! |
@HwangTaehyun Thanks! |
This issue is critical for Japanese users too. |
@kolt-suzuki I will take care of it this week. |
The PR from @HwangTaehyun uses keypress event which is unfortunately deprecated (source: https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event#Deprecated) I don't want to keep deprecated features in the code. |
Waiting for ticket to merged.... |
🎉 This issue has been resolved in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@HwangTaehyun Thank you for your contribution! |
@supersnager Thank you for your effort! |
Hi, thank you for intuitive and awesome chat-ui library.
I'm using it well, but there are some bugs like following situations.
OnKeyDown event occurs twice when typing in Korean and then hitting enter. So Last Korean Character printed one more time.
![Korean Input Bug](https://user-images.githubusercontent.com/42465090/107186368-7b4f5e80-6a27-11eb-9a12-bde0378ca20b.gif)
The text was updated successfully, but these errors were encountered: