Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnKeyDown event occurs twice when typing in Korean and then hitting enter #9

Closed
HwangTaehyun opened this issue Feb 8, 2021 · 10 comments · Fixed by #10
Closed

OnKeyDown event occurs twice when typing in Korean and then hitting enter #9

HwangTaehyun opened this issue Feb 8, 2021 · 10 comments · Fixed by #10
Assignees
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@HwangTaehyun
Copy link
Contributor

Hi, thank you for intuitive and awesome chat-ui library.

I'm using it well, but there are some bugs like following situations.

OnKeyDown event occurs twice when typing in Korean and then hitting enter. So Last Korean Character printed one more time.
Korean Input Bug

@supersnager
Copy link
Contributor

@HwangTaehyun Thanks for PR. I will reproduce this bug before merging, and check if everything works for other edge cases as well.

@supersnager supersnager added bug Something isn't working good first issue Good for newcomers labels Feb 8, 2021
@HwangTaehyun
Copy link
Contributor Author

I checked again, and it works fine in Chrome on Windows, and it seems that this problem occurs in Chrome on Mac. Please note. Thank you!

@supersnager
Copy link
Contributor

@HwangTaehyun Thanks!

@supersnager supersnager self-assigned this Feb 12, 2021
@kolt-suzuki
Copy link

This issue is critical for Japanese users too.
I hope it would be merged quickly.

@supersnager
Copy link
Contributor

@kolt-suzuki I will take care of it this week.

@supersnager
Copy link
Contributor

supersnager commented Apr 11, 2021

@HwangTaehyun @kolt-suzuki

The PR from @HwangTaehyun uses keypress event which is unfortunately deprecated (source: https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event#Deprecated)

I don't want to keep deprecated features in the code.
However, I have done some research and it looks like there is no other workaround for this chrome bug.
So I have tested the PR and it's ok. I will merge it, but @HwangTaehyun please change the commit message as I mentioned in the PR comment.

@bibek-magar
Copy link

Waiting for ticket to merged....

@supersnager
Copy link
Contributor

🎉 This issue has been resolved in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@supersnager
Copy link
Contributor

@HwangTaehyun Thank you for your contribution!

@HwangTaehyun
Copy link
Contributor Author

@supersnager Thank you for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
4 participants