Streams may not open when updating to Streamlink 6 or later.

[lewisje]

This is really an issue that requires the end-user to change configuration settings that worked with previous versions of Streamlink but no longer work with Streamlink.

More specifically, in Streamlink's config file, the player setting strictly specifies the player executable, with no command-line arguments, and the player-args setting is required in order to send command-line arguments; the same applies at the command line, including the way the "Base command" is specified in Chatty's own settings.

As an example, if you originally had

"C:\Program Files\Streamlink\bin\streamlink.exe" -p "C:\Program Files\VideoLAN\VLC\vlc.exe --file-caching=60000 --network-caching=100"

you will need to change it to

"C:\Program Files\Streamlink\bin\streamlink.exe" -p "C:\Program Files\VideoLAN\VLC\vlc.exe" --player-args "--file-caching=60000 --network-caching=100"

or if your Streamlink file originally had

player="C:\Program Files\VideoLAN\VLC\vlc.exe --file-caching=60000 --network-caching=100"

it will need to be changed to

player=C:\Program Files\VideoLAN\VLC\vlc.exe
player-args=--file-caching=60000 --network-caching=100

(That's right, in the config file, those settings should no longer be quoted.)

I found this problem described in Chatterino and that Issue inspired me to post this one: Chatterino/chatterino2#4730

It referred to the release notes for Streamlink 6.0.0, although 6.1.0 was released last week, so people who upgraded recently might have missed the relevant breaking change: https://github.com/streamlink/streamlink/releases/tag/6.0.0

Describe the bug
When the user tries to launch a stream in Chatty, the stream does not launch; if the "select" quality is chosen, Streamlink shows the error (Player executable not found).

To Reproduce
[Steps to reproduce the behavior:

1. Go to any live stream.
2. Right-click in an empty area.
3. Mouse-over "Streamlink" and click a quality option.
4. Go to the Extra>Streamlink menu to see that the stream instantly closed, or if "select" was chosen, there is an error message.

Expected behavior
The stream launches or the select dialog shows the available quality options.

Debug Log
(no debug log necessary here)

Screenshots/Videos
(none needed)

Additional information (please complete the following information):

• OS (e.g. Windows 7): Windows 10 22H2 Build 19045
• Chatty Version (e.g. v0.9.1 Standalone): v0.25 Standalone
• Java Version (if not using Standalone): (irrelevant)
• When has the issue first occurred (Chatty Version or timeframe): today, but the issue has existed for a couple of weeks; I only upgraded Streamlink today
• How often does the issue occur (every time, sometimes): every time

Additional context
This is really a breaking change in Streamlink but I figured Chatty users might want to be warned about it; I would close this issue myself if I could, because I just want the message to be out there.