Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linting issues in components #61

Closed
jahndan opened this issue Mar 1, 2024 · 1 comment
Closed

fix linting issues in components #61

jahndan opened this issue Mar 1, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jahndan
Copy link
Collaborator

jahndan commented Mar 1, 2024

namely Header.js and FilterSearch.js have linting errors

also it would be nice to set up a thing that prevents pull requests from being accepted while there are still linting errors (after the above two are fixed)
@chaunmt
Copy link
Owner

chaunmt commented Mar 8, 2024

Can you put in README how to check for lint error?
Also, Header.js is good now and @doggu is working on cleaning the 3 search files.

@chaunmt chaunmt added enhancement New feature or request documentation Improvements or additions to documentation labels Mar 8, 2024
@jahndan jahndan closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaunmt @jahndan