Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German and Korean (2-set & 3-set) keyboard #13

Open
N3v1 opened this issue Dec 3, 2023 · 6 comments
Open

German and Korean (2-set & 3-set) keyboard #13

N3v1 opened this issue Dec 3, 2023 · 6 comments
Assignees

Comments

@N3v1
Copy link

N3v1 commented Dec 3, 2023

#3 Parent issue

Hi @chavi362 i opened this issue to plan the German & Korean keyboard

I have 2 questions:

  • What do I have to do?
  • How should I add the letters?
@chavi362
Copy link
Owner

chavi362 commented Dec 3, 2023

Thank you so much!!!
in VirtualKeyBoard.jsx you have to edit the placeholders array her:const [isEmojiActive, setIsEmojiActive] = useState(false);
const placeholders = [
"הקלד כאן",
"type here",
"أكتب هنا",
"друкуйте тут",
"напечатайте здесь",
];
and add suitable placeholders for the new languege.
then edit the switch in changeLanguage to support the new langueges.
Also update in KeyBoardLanguage.jsx function handleChange and the select tag.
Good Luck!
Please star the repository!

@N3v1
Copy link
Author

N3v1 commented Dec 3, 2023

1000px-KB_South_Korea

That's how a Korean keyboard (2-set) should look like:
For example look at the 'Q' we have two possibilities for that key, either 'ㅂ' (p or b) or 'ㅃ' (pp) if you do a shift click.
How should/can I implement this?

So a key should contain these elements:

  • English letter
  • Korean letter
    (-) Korean second letter (when shift is pressed)

cc: @chavi362

@N3v1
Copy link
Author

N3v1 commented Dec 3, 2023

Thank you so much!!! in VirtualKeyBoard.jsx you have to edit the placeholders array her:const [isEmojiActive, setIsEmojiActive] = useState(false); const placeholders = [ "הקלד כאן", "type here", "أكتب هنا", "друкуйте тут", "напечатайте здесь", ]; and add suitable placeholders for the new languege. then edit the switch in changeLanguage to support the new langueges. Also update in KeyBoardLanguage.jsx function handleChange and the select tag. Good Luck! Please star the repository!

Ok thx I'll look into it

@N3v1
Copy link
Author

N3v1 commented Dec 3, 2023

@chavi362 I'm almost done with the Korean keyboard

Do I also have to add the Korean letters into ~/src/Components/KeyBoard.jsx and create a new Array in KeyBoard(props)?

See #14

@N3v1 N3v1 mentioned this issue Dec 3, 2023
@chavi362
Copy link
Owner

chavi362 commented Jan 1, 2024

@N3v1 please note that now you have an option to add also a shift characters array!
Now the task of adding language is more easier please look in the description in #3

@chavi362
Copy link
Owner

chavi362 commented Jan 9, 2024

@N3v1 are you still working? a good expalaintion of how to do that apper in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants