Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Protection Upgrade #55

Closed
Delerium opened this issue Jun 23, 2015 · 9 comments
Closed

General Protection Upgrade #55

Delerium opened this issue Jun 23, 2015 · 9 comments

Comments

@Delerium
Copy link

The armor lists protection values in it's description, but actually provides no armor protection against attacks, and does not increase the armor bar above the hearts in the UI.

@chbachman chbachman reopened this Jun 23, 2015
@chbachman
Copy link
Owner

Come on github, I only mentioned it, not closed it.

@Delerium
Copy link
Author

tested the new version, still not working. Very fast fix response though. props!

@chbachman
Copy link
Owner

Are you increasing the percentage under the config tab? 

It defaults to 0% protection.

On Tue, Jun 23, 2015 at 12:39 PM, Delerium notifications@github.com
wrote:

tested the new version, still not working. Very fast fix response though. props!

Reply to this email directly or view it on GitHub:
#55 (comment)

@wei2gao
Copy link

wei2gao commented Jun 23, 2015

I think that the armor needs to have some of the protection upgrades to really be effective against damage.

@Delerium
Copy link
Author

I'm playing it native on Horizons: Daybreaker. I checked the config, and it lists values for each damage type modifier, but nothing listed for base "protection" which every armor should have, as not all mobs will fit into these "damage type" categories. There are no upgrades for "base armor rating", and without any base protection the armor is rather useless. I'd be happy with upgrades that provide different levels of base protection, that would be cool.

Config values:
"defensive values" {
D:"Arthropod Protection"=0.75
D:"Fire Protection"=0.75
D:"Lava Protection"=0.75
D:"Magic Protector"=0.20000000298023224
D:"Player Protector"=0.8999999761581421
D:"Unblockable Protector"=0.10000000149011612
D:"Undead Protection"=0.75
D:"Wither Protector"=0.20000000298023224
D:upgrade.chbachman.explosionProtector.name=0.75
}

@chbachman chbachman changed the title Armor provides no base protection. General Protection Upgrade Jun 24, 2015
@chbachman
Copy link
Owner

Am I correct with my changes to the question?

@Delerium
Copy link
Author

Yeah that looks about right. Right now I've been swapping armor sets between my combat set and this one for utility. Would be great to just use one set.

@Delerium
Copy link
Author

This is of course your choice, but since you are trying to keep things unconventional and wanted something unique, perhaps this could be split into "Melee protection" and "Projectile Protection" instead of one "general protection". I'm just trying to figure out a modular way of getting protection against those edge cases that don't have an upgrade for it, like melee or ranged attacks from creatures that aren't undead or arachnid (no protection listed for that type.)

@chbachman
Copy link
Owner

Ok, added in the most recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants