Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names field mandatory for k8s/openshift, optional for plugins #9

Closed
l0rd opened this issue Feb 5, 2020 · 2 comments · Fixed by #35
Closed

Names field mandatory for k8s/openshift, optional for plugins #9

l0rd opened this issue Feb 5, 2020 · 2 comments · Fixed by #35
Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request
Milestone
2.0

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 5, 2020 •
edited
Loading

  • alias should not be used anymore
  • name should be mandatory for kubernetes/openshift/containers components
  • name should be optional for plugins components
  • If name is not specified for a component of type plugin it should be inferred from its id/url field (id/url are used as name if its not specified explicitly)
### a Devfile spec

- container:
     name: tooling-container # <-- mandatory
     image: busybox
     mountSources: true
     endpoints:
       - name: petclinic-web-server

- kubernetes:
     name: mongodb # <-- mandatory
     reference: .../deployment.yaml # <-- already have a metadata.name: 'database1'

- plugin:
     name: vscode-java # <-- optional
     id: ms-vscode/vscode-java/1.1.1
@l0rd l0rd added kind/enhancement New feature or request area/api Enhancement or issue related to the api/devfile specification labels Feb 5, 2020
@l0rd l0rd mentioned this issue Feb 5, 2020
Closed
28 tasks
@l0rd l0rd changed the title Components names: mandatory in DevWorkspaces, optional (alias) in Devfiles Components names mandatory for k8s/openshift, optional for plugins Mar 10, 2020
@l0rd l0rd changed the title Components names mandatory for k8s/openshift, optional for plugins Names field mandatory for k8s/openshift, optional for plugins Mar 10, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Mar 10, 2020

Discussed and agreed on this spec.

davidfestal added a commit that referenced this issue Apr 3, 2020
@davidfestal
Implement agreement on issue #9
6c99166 
Signed-off-by: David Festal <dfestal@redhat.com>
@amisevsk amisevsk mentioned this issue Apr 3, 2020
Merged
davidfestal added a commit that referenced this issue Apr 10, 2020
@davidfestal
Fix PR comments about issue #9
636fff6 
PR comment is here: #35 (comment)

Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal added a commit that referenced this issue Apr 22, 2020
@davidfestal @sleshchenko
Implement agreed-on devfile 2.0 issues (#35)
f9e7352 
* Implement agreement on issue #18
* Implement agreement on issue #17
* Implement agreement on issue #21
* Implement agreement on issue #22
* Implement agreement on issue #27
* Implement agreement on issue #9
* Implement agreement on issue #10
* Fix PR comments about issue #9 PR comment #35 (comment)
* Fix PR comments about issue #17 PR comment #35 (comment)
* Implement agreement on issue #14 and  #19
* Add the spring boot example
* Implement agreement on issue #32
* Fix last PR comments

Signed-off-by: David Festal <dfestal@redhat.com>

Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
@l0rd l0rd added this to the 2.0.0 milestone Jun 16, 2020
@davidfestal davidfestal linked a pull request Jun 23, 2020 that will close this issue
Implement agreed-on devfile 2.0 issues #35
Merged
@davidfestal
Copy link
Collaborator

Implemented

@elsony elsony mentioned this issue Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Implement agreed-on devfile 2.0 issues devfile/api
2 participants
@l0rd @davidfestal